Closed Dante291 closed 7 months ago
We have these basic policies to make the approval process smoother for our volunteer team.
Please make sure your code passes all tests. Our test code coverage system will fail if either of these two conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.
Do not assign reviewers. Our Queue Monitors will review your PR and assign them. When your PR has been assigned reviewers contact them to get your code reviewed and approved via:
Your reviewer(s) will have the following roles:
:dart: Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.
@palisadoes @noman2002 @AVtheking
Instead of adding userAppProfile schema in the App I have added isSuperAdmin
field and have updated the fetching and storing user Info (createdOrganisation, adminFor and isSuperAdmin), have updated queries such that logIn and SignUp work properly.
Please let me know if this approach is fine or do I need to add more field from appUserProfile document?
We want no admin features in the mobile app, so you'll need to assume a user login.
@palisadoes sorry I didn't get you sir, what you mean by I will need to assume user login.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 95.54%. Comparing base (
eb333ad
) to head (077e138
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@palisadoes This is ready for review
I was mixing up Admin where there are separate routes for Admin and User screens.
- No admin features in the mobile app at this time. We want to keep it simple
This means we do not require adminFor field in app ? @Dante291 if it was previously not being used then remove it
I was mixing up Admin where there are separate routes for Admin and User screens.
- No admin features in the mobile app at this time. We want to keep it simple
This means we do not require adminFor field in app ? @Dante291 if it was previously not being used then remove it
I am gonna let this be in the userInfo schema as we might have some support for admin user type in future, this field will be helpful that time.
I was mixing up Admin where there are separate routes for Admin and User screens.
- No admin features in the mobile app at this time. We want to keep it simple
This means we do not require adminFor field in app ? @Dante291 if it was previously not being used then remove it
I am gonna let this be in the userInfo schema as we might have some support for admin user type in future, this field will be helpful that time.
if we are going to have admin support in feature then okay
@noman2002 @literalEval @Ayush0Chaudhary
Please review
What kind of change does this PR introduce?
Fixes userType in the app by adding isSuperAdmin filed in user schema.
Issue Number:
Fixes 2373 (not tagging issue as that will close it)
Did you add tests for your changes?
No
Does this PR introduce a breaking change?
Somewhat yeah
Have you read the contributing guide?
Yes