PalisadoesFoundation / talawa

Community Organization Management Software. Click on the link below to see our documentation.
https://docs.talawa.io/
GNU General Public License v3.0
311 stars 438 forks source link

Unittests for organization_feed_view_model.dart #2390

Closed YoussefMoRabie closed 7 months ago

YoussefMoRabie commented 7 months ago

What kind of change does this PR introduce?

Unittests for organization_feed_view_model.dart

Issue Number:

Fixes #1009

Did you add tests for your changes?

Yes

Have you read the contributing guide?

Yes

github-actions[bot] commented 7 months ago

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if either of these two conditions occur:

  1. The overall code coverage drops below the target threshold of the repository
  2. Any file in the pull request has code coverage levels below the repository threshold

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

Do not assign reviewers. Our Queue Monitors will review your PR and assign them. When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

Other

:dart: Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.

YoussefMoRabie commented 7 months ago

@noman2002 @palisadoes please review!!

Cioppolo14 commented 7 months ago

@Yousef-Rabia Please fix the failing tests.

YoussefMoRabie commented 7 months ago

@Cioppolo14 I think I should fix it in another PR because it's a different issue

YoussefMoRabie commented 7 months ago

removePost function dosn't remove post from posts list and remove it only from DB

image

if I update removePost function all tests will pass

image

Please explain to me if I have misunderstood

YoussefMoRabie commented 7 months ago

Review please @noman2002 @Kevoniat @Ayush0Chaudhary @CyberWake @literalEval @DMills27

Cioppolo14 commented 7 months ago

@Yousef-Rabia Please fix the issue in this PR. In order for it to be ready for reviewers, the failing tests must be passing.

YoussefMoRabie commented 7 months ago

@Cioppolo14 Done

Dante291 commented 7 months ago

image

Please try to get coverage to 100%

Olatade commented 7 months ago

@literalEval @DMills27 please can you review?

palisadoes commented 7 months ago

Your PR has unnecessary files that don’t relate to your issue. This is causing the tests to fail.

You can from the PR by running the commands below from the root directory of the repository

git add -u git reset HEAD path/to/file git commit

YoussefMoRabie commented 7 months ago

Sorry for the trouble

YoussefMoRabie commented 7 months ago

Please review so I can work on other Issues @noman2002 @Kevoniat @Ayush0Chaudhary @CyberWake @literalEval @DMills27

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.83%. Comparing base (4c1e931) to head (0d1ba2c). Report is 1 commits behind head on develop.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #2390 +/- ## =========================================== + Coverage 95.68% 95.83% +0.14% =========================================== Files 152 152 Lines 7395 7396 +1 =========================================== + Hits 7076 7088 +12 + Misses 319 308 -11 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.