Closed YoussefMoRabie closed 7 months ago
We have these basic policies to make the approval process smoother for our volunteer team.
Please make sure your code passes all tests. Our test code coverage system will fail if either of these two conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.
Do not assign reviewers. Our Queue Monitors will review your PR and assign them. When your PR has been assigned reviewers contact them to get your code reviewed and approved via:
Your reviewer(s) will have the following roles:
:dart: Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.
@noman2002 @palisadoes please review!!
@Yousef-Rabia Please fix the failing tests.
@Cioppolo14 I think I should fix it in another PR because it's a different issue
removePost function dosn't remove post from posts list and remove it only from DB
if I update removePost function all tests will pass
Please explain to me if I have misunderstood
Review please @noman2002 @Kevoniat @Ayush0Chaudhary @CyberWake @literalEval @DMills27
@Yousef-Rabia Please fix the issue in this PR. In order for it to be ready for reviewers, the failing tests must be passing.
@Cioppolo14 Done
Please try to get coverage to 100%
@literalEval @DMills27 please can you review?
Your PR has unnecessary files that don’t relate to your issue. This is causing the tests to fail.
pubspec.lock
You can from the PR by running the commands below from the root directory of the repository
git add -u git reset HEAD path/to/file git commit
Sorry for the trouble
Please review so I can work on other Issues @noman2002 @Kevoniat @Ayush0Chaudhary @CyberWake @literalEval @DMills27
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 95.83%. Comparing base (
4c1e931
) to head (0d1ba2c
). Report is 1 commits behind head on develop.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
What kind of change does this PR introduce?
Unittests for organization_feed_view_model.dart
Issue Number:
Fixes #1009
Did you add tests for your changes?
Yes
Have you read the contributing guide?
Yes