Closed Yousef-Rabia closed 3 months ago
We have these basic policies to make the approval process smoother for our volunteer team.
Please make sure your code passes all tests. Our test code coverage system will fail if either of these two conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.
Do not assign reviewers. Our Queue Monitors will review your PR and assign them. When your PR has been assigned reviewers contact them to get your code reviewed and approved via:
Your reviewer(s) will have the following roles:
:dart: Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.
Please review so I can work on other Issues @noman2002 @Kevoniat @Ayush0Chaudhary @CyberWake @literalEval @DMills27
@Yousef-Rabia Please fix the failing tests. We will assign reviewers once the tests are passed.
@Yousef-Rabia Are you working on this?
@Cioppolo14 Yes, but I think I need a help with this error
@noman2002 @Ayush0Chaudhary please can you review ?
What kind of change does this PR introduce?
Remove shadow from buttons
Issue Number:
Fixes #2393
Did you add tests for your changes?
No
Snapshots/Videos:
Have you read the contributing guide?
Yes