PalisadoesFoundation / talawa

Community Organization Management Software. Click on the link below to see our documentation.
https://docs.talawa.io/
GNU General Public License v3.0
311 stars 438 forks source link

Upgrade package `syncfusion_flutter_datepicker` 24.2.4 to 24.2.7. #2401

Closed palisadoes closed 6 months ago

palisadoes commented 7 months ago

Rationale

  1. This was previously attempted by the automated dependabot job but the PR tests failed.
  2. This issue has been created to fix the issue as there may be multiple dependency requirements that need updating

This is a major revision upgrade and many files may need to be updated to the new syntax, functions, methods and classes

Task

Upgrade package syncfusion_flutter_datepicker 24.2.4 to 24.2.7.

Background Failing PRs

Release Note Details

Commits


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
ArinNigam commented 7 months ago

@Cioppolo14 @palisadoes Can you assign me this issue?

ArinNigam commented 7 months ago
image image

Releases in flutter 3.19 https://docs.flutter.dev/release/breaking-changes/key-event-migration

image

Conclusion So I am guessing that we'll have to migrate the project to flutter sdk 13.9.0 before to fix this issue since the pacakge syncfusion_flutter_datepicker is using date_picker that invokes this HardwareKeyboard.instance which is a part of flutter sdk 13.9.0

image

i) syncfusion_flutter_datepicker 24.2.4

image

ii) syncfusion_flutter_datepicker 24.2.7


@Cioppolo14 requesting for review

palisadoes commented 7 months ago

We have an issue to upgrade to the latest SDK here. Are you willing to work on that too?

ArinNigam commented 7 months ago

@palisadoes yeah sure I can try that but I ran with some errors when I tried working on it before. It seems a lot of code needs to be changed for that. You can assign me though I'll try and get back at it.

palisadoes commented 7 months ago

You'll have to comment on the issue to be assigned

ArinNigam commented 6 months ago

This issue is resolved in the PR #2413