Closed soaham-pimparkar closed 4 months ago
We have these basic policies to make the approval process smoother for our volunteer team.
Please make sure your code passes all tests. Our test code coverage system will fail if either of these two conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.
Do not assign reviewers. Our Queue Monitors will review your PR and assign them. When your PR has been assigned reviewers contact them to get your code reviewed and approved via:
Your reviewer(s) will have the following roles:
:dart: Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.
@soaham-pimparkar Please fix the first comment so that each issue listed automatically closes. The PR_GUIDELINES.md file has details.
Also, please fix the failing test.
What kind of change does this PR introduce?
-> Fixed the navigation, where app used to navigate back to the home page instead of the Select Language page on clicking the Select Language button.
Issue Number:
-> fixes #2394
Did you add tests for your changes?
-> No
Does this PR introduce a breaking change?
-> No
Have you read the contributing guide?
-> Yes
Snapshots/Videos:
https://github.com/PalisadoesFoundation/talawa/assets/113767354/9ada2e8b-2691-4597-a8ca-8c78c018903d