github-actions[bot]
commented
4 months ago Our Pull Request Approval Process
We have these basic policies to make the approval process smoother for our volunteer team.
Testing Your Code
Please make sure your code passes all tests. Our test code coverage system will fail if either of these two conditions occur:
- The overall code coverage drops below the target threshold of the repository
- Any file in the pull request has code coverage levels below the repository threshold
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.
Reviewers
Do not assign reviewers. Our Queue Monitors will review your PR and assign them. When your PR has been assigned reviewers contact them to get your code reviewed and approved via:
- comments in this PR or
- our slack channel
Reviewing Your Code
Your reviewer(s) will have the following roles:
- arbitrators of future discussions with other contributors about the validity of your changes
- point of contact for evaluating the validity of your work
- person who verifies matching issues by others that should be closed.
- person who gives general guidance in fixing your tests
Other
:dart: Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.
ArinNigam
Cioppolo14
What kind of change does this PR introduce? It updates the flutter sdk to 13.9.0 and dart 3.3.0
Issue Number:
Fixes #2383 #2401
Did you add tests for your changes? Yes, updated flutter version for tests
Snapshots/Videos: NA
If relevant, did you update the documentation? No
Summary https://github.com/PalisadoesFoundation/talawa/issues/2383 https://github.com/PalisadoesFoundation/talawa/issues/2401 The following issues are solved by the PR. The sole motivation to make this change was to make the app compatible with the latest flutter version since packages have also been upgraded to make use of the latest flutter version which were causing errors because of lower version.
The app is migrated to the latest version by taking references from the following article: https://medium.com/@iam.umairimran/flutter-app-migration-guide-updating-to-flutter-3-19-0-ab8b66008838
Does this PR introduce a breaking change? Yes, It does make an impactful change since it updates the app to make use of the latest flutter sdk version that is 3.19.0. It changes android/build.gradle and app/build.gradle files and added changes in github workflows.
Other information However because of continuous failing of custom_lint in the github/workflows I am creating a new issue For reference One can go to .github/workflows/check_ignore and check for the following commented out code
Have you read the contributing guide? Yes