search

PalisadoesFoundation / talawa

Community Organization Management Software. Click on the link below to see our documentation.
https://docs.talawa.io/
GNU General Public License v3.0
306 stars 435 forks source link

ptch: minor UI fix of event image loaders #2422

Closed am-casper closed 3 months ago

am-casper commented 3 months ago

What kind of change does this PR introduce?

This is a patch update. It improves the UI of the event image loaders, which was earlier an oval.

Issue Number: #2421

Fixes #2421

Did you add tests for your changes?

Updated a unit-test for the loader.

Snapshots/Videos: Before: image After: image

Summary

The UI for loaders looked very unpleasant and unstable. This can make the user less interested in the app, in case internet connection is slow.

Does this PR introduce a breaking change?

No

Have you read the contributing guide?

Yes

github-actions[bot] commented 3 months ago

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if either of these two conditions occur:

  1. The overall code coverage drops below the target threshold of the repository
  2. Any file in the pull request has code coverage levels below the repository threshold

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

Do not assign reviewers. Our Queue Monitors will review your PR and assign them. When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

Other

:dart: Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.

Cioppolo14 commented 3 months ago

Thank you for your submission, the issue related to this is going to be closed as not planned, so I am going to close this PR.