search

PalisadoesFoundation / talawa

Community Organization Management Software. Click on the link below to see our documentation.
https://docs.talawa.io/
GNU General Public License v3.0
306 stars 434 forks source link

new unittests added - validate empty text fields, loading greeting images and unfocus text fields. #2432

Closed chiragtyagi2003 closed 3 months ago

chiragtyagi2003 commented 3 months ago

What kind of change does this PR introduce?

Unittests for pre_auth_view_models/login_view_model.dart

Issue Number:

Fixes #1007

Did you add tests for your changes?

No, I added unittests for existing code.

Snapshots/Videos:

Not relevant

If relevant, did you update the documentation?

Not Relevant

Summary

The new unit tests are for validation of empty email and password text fields, correct loading of greetings image and also unfocusing of the text fields after login.

Does this PR introduce a breaking change?

No

Other information

Have you read the contributing guide?

Yes

github-actions[bot] commented 3 months ago

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if either of these two conditions occur:

  1. The overall code coverage drops below the target threshold of the repository
  2. Any file in the pull request has code coverage levels below the repository threshold

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

Do not assign reviewers. Our Queue Monitors will review your PR and assign them. When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

Other

:dart: Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.

Huy1996 commented 3 months ago

@chiragtyagi2003 Please fix the failing test.

Cioppolo14 commented 3 months ago

@chiragtyagi2003 Please fix the failing tests.

chiragtyagi2003 commented 3 months ago

@Cioppolo14 I believe there are some changes required in the code, as the log suggests issues found in finding ancestors widgets, due to which tests are failing.

palisadoes commented 3 months ago

This is an update on the PR merging freeze:

  1. In the next few hours we will be merging the develop-userTypeFix branch into the develop branch.
  2. The develop-userTypeFix branch was created to fix a long standing design flaw where Admins were Admins of all organizations, not specific ones.
  3. The userType field has been removed from the User collection and it has been replaced by an appUserProfileId field.
    1. This field is null if the user isn’t registered to use the apps. This will help people to add users manually during the event checkin process, or if an Admin wants to manually add someone in the Admin dashboard.
    2. When not null the AppUserProfileID will reference a AppUserProfile collection with App related information such as the organizations for which a user may be an Admin.
    3. The updated schema can be found here https://github.com/PalisadoesFoundation/talawa-api/blob/develop-userTypeFix/schema.graphql
    4. This is the parent issue that we have been using to track progress:
      1. https://github.com/PalisadoesFoundation/talawa-api/issues/1965
  4. This merge will cause some conflicts in your PR.

We decided to do this at the beginning of the weekend to give us all time to adjust PR code and create bug fixes that may arise.

Update your code at or after midnight GMT on the morning of March 23, 2024. (5:30am IST).

If your PRs have already been approved, request a re-review after fixing the conflicts and refactoring to the new AppUserProfileID methodology.

Cioppolo14 commented 3 months ago

@chiragtyagi2003 Please fix the failing tests.

github-actions[bot] commented 3 months ago

This pull request did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please verify it has no conflicts with the develop branch and rebase if needed. Mention it now if you need help or give permission to other people to finish your work.

palisadoes commented 3 months ago

Closing as stale. We can reopen it if you'd like