search

PalisadoesFoundation / talawa

Community Organization Management Software. Click on the link below to see our documentation.
https://docs.talawa.io/
GNU General Public License v3.0
306 stars 434 forks source link

Talawa branch for pr 4 #2445

Closed nenezoe closed 2 months ago

nenezoe commented 3 months ago

Unit Test on edit profile view paga For proper functioning of edit profile page

2440

github-actions[bot] commented 3 months ago

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if either of these two conditions occur:

  1. The overall code coverage drops below the target threshold of the repository
  2. Any file in the pull request has code coverage levels below the repository threshold

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

Do not assign reviewers. Our Queue Monitors will review your PR and assign them. When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

Other

:dart: Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.25%. Comparing base (3a23de5) to head (b7feffe). Report is 7 commits behind head on develop.

:exclamation: Current head b7feffe differs from pull request most recent head 8d7178a. Consider uploading reports for the commit 8d7178a to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #2445 +/- ## ======================================== Coverage 96.25% 96.25% ======================================== Files 152 152 Lines 7524 7524 ======================================== Hits 7242 7242 Misses 282 282 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Olatade commented 3 months ago

@noman2002 @DMills27 please review

github-actions[bot] commented 2 months ago

This pull request did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please verify it has no conflicts with the develop branch and rebase if needed. Mention it now if you need help or give permission to other people to finish your work.

noman2002 commented 2 months ago

There is no issue linked to this PR.

Cioppolo14 commented 2 months ago

@nenezoe I am closing this. Please fill out the PR template completely, and submit a new PR.