search

PalisadoesFoundation / talawa

Community Organization Management Software. Click on the link below to see our documentation.
https://docs.talawa.io/
GNU General Public License v3.0
306 stars 434 forks source link

Feat: add count-changed-files and check-unauthorized pr workflow #2447

Closed lakshz closed 3 months ago

lakshz commented 3 months ago

What kind of change does this PR introduce? This PR adds two workflows in pull-request.yml:

Issue Number:

Fixes #2444

Did you add tests for your changes?

Snapshots/Videos:

If relevant, did you update the documentation?

Summary

Does this PR introduce a breaking change?

Other information

Have you read the contributing guide?

github-actions[bot] commented 3 months ago

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if either of these two conditions occur:

  1. The overall code coverage drops below the target threshold of the repository
  2. Any file in the pull request has code coverage levels below the repository threshold

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

Do not assign reviewers. Our Queue Monitors will review your PR and assign them. When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

Other

:dart: Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.

pranshugupta54 commented 3 months ago

@lakshz, too many changes in white spaces and double / single quotes.

lakshz commented 3 months ago

Sorry, let me fix those

lakshz commented 3 months ago

Formatting changes are removed now.

pranshugupta54 commented 3 months ago

@lakshz, previously used code should be removed too. Like if the counting is implemented in pr workflow, then it should be removed from existing files which won't be used after this. Right?

Cioppolo14 commented 3 months ago

@lakshz Please let the queue monitors add reviewers.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.25%. Comparing base (8652d99) to head (b41826f). Report is 12 commits behind head on develop.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #2447 +/- ## =========================================== + Coverage 95.74% 96.25% +0.50% =========================================== Files 152 152 Lines 7518 7524 +6 =========================================== + Hits 7198 7242 +44 + Misses 320 282 -38 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

lakshz commented 3 months ago

@Cioppolo14 PR reviews are automatically assigned to code owners defined in CODEOWNERS file.