Bug Fix: Custom Lint - Githubissues

ArinNigam commented 3 months ago

What kind of change does this PR introduce?

Issue Number:

Fixes #2428

Did you add tests for your changes? No

Snapshots/Videos:

snippet (19)

If relevant, did you update the documentation? No, but apparently there was no documentation for ChatMessage which is why check_ignore.py was failing but it must be in some later PR that it was added in talawa-docs

Summary

Other information NA

Have you read the contributing guide? Yes

github-actions[bot] commented 3 months ago

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if either of these two conditions occur:

The overall code coverage drops below the target threshold of the repository
Any file in the pull request has code coverage levels below the repository threshold

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

Do not assign reviewers. Our Queue Monitors will review your PR and assign them. When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

comments in this PR or
our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

arbitrators of future discussions with other contributors about the validity of your changes
point of contact for evaluating the validity of your work
person who verifies matching issues by others that should be closed.
person who gives general guidance in fixing your tests

Other

:dart: Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.

dhanagopu commented 3 months ago

@ArinNigam Please fix failing checks

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.25%. Comparing base (73584a3) to head (b182b94).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## develop #2449 +/- ## ======================================== Coverage 96.25% 96.25% ======================================== Files 152 152 Lines 7524 7524 ======================================== Hits 7242 7242 Misses 282 282 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ArinNigam commented 3 months ago

@dhanagopu failing checks are due to the changes made in check_ignore.py file. A part of code was commented by me in #2413 because of failing workflows and was made as a separate issue to go ahead with the previous PR.

Cioppolo14 commented 3 months ago

@ArinNigam Please let the queue monitors assign reviewers.