PalisadoesFoundation / talawa

Community Organization Management Software. Click on the link below to see our documentation.
https://docs.talawa.io/
GNU General Public License v3.0
306 stars 434 forks source link

Size of circular progress indicator has fixed to normal size #2460

Closed SumitPareek2401 closed 2 months ago

SumitPareek2401 commented 2 months ago

What kind of change does this PR introduce? a bugfix

Issue Number:

Fixes #2391

Did you add tests for your changes? Yes

Snapshots/Videos:

https://github.com/PalisadoesFoundation/talawa/assets/122019171/b21b47b6-3744-4108-976e-53650eddf505

If relevant, did you update the documentation?

Summary To fix the progress indicator size which is unsuitable for the UI. The loading circular progress indicator is stretched on the UI and has been fixed.

Does this PR introduce a breaking change?

Other information

Have you read the contributing guide? Yes

github-actions[bot] commented 2 months ago

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if either of these two conditions occur:

  1. The overall code coverage drops below the target threshold of the repository
  2. Any file in the pull request has code coverage levels below the repository threshold

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

Do not assign reviewers. Our Queue Monitors will review your PR and assign them. When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

Other

:dart: Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.

Cioppolo14 commented 2 months ago

@SumitPareek2401 Please do not add reviewers, we have queue monitors such as myself who review the PR first, and assign it to reviewers when it is ready. Please fix the failing tests.

github-actions[bot] commented 2 months ago

This pull request did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please verify it has no conflicts with the develop branch and rebase if needed. Mention it now if you need help or give permission to other people to finish your work.

palisadoes commented 2 months ago

Closing as abandoned