search

PalisadoesFoundation / talawa

Community Organization Management Software. Click on the link below to see our documentation.
https://docs.talawa.io/
GNU General Public License v3.0
306 stars 434 forks source link

Bug-Fix SignUp #2477

Closed ArinNigam closed 2 months ago

ArinNigam commented 2 months ago

What kind of change does this PR introduce? Bug-Fix

Issue Number: Fixes #2454

Did you add tests for your changes? Yes, I have made changed in the unit tests to make sure workflow doesn't fail.

Snapshots/Videos: SignUp is working fine now

https://github.com/PalisadoesFoundation/talawa/assets/99138286/8834c360-8894-48ef-92bb-ccebd466caca

If relevant, did you update the documentation? No

Summary SignUp was failing for the app continuously which was acting as an hindrance to the other issues after the signup process. It solves the problem of SignUp and now the user can log in after signing it without any problem.

Does this PR introduce a breaking change? Yes

Have you read the contributing guide? Yes

github-actions[bot] commented 2 months ago

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if either of these two conditions occur:

  1. The overall code coverage drops below the target threshold of the repository
  2. Any file in the pull request has code coverage levels below the repository threshold

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

Do not assign reviewers. Our Queue Monitors will review your PR and assign them. When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

Other

:dart: Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.42%. Comparing base (0087e3a) to head (8dc7e50). Report is 5 commits behind head on develop.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #2477 +/- ## ======================================== Coverage 96.42% 96.42% ======================================== Files 152 152 Lines 7587 7588 +1 ======================================== + Hits 7316 7317 +1 Misses 271 271 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.