PalisadoesFoundation / talawa

Community Organization Management Software. Click on the link below to see our documentation.
https://docs.talawa.io/
GNU General Public License v3.0
306 stars 434 forks source link

Feature: Display Additional Organization and Address Data #2478

Closed Dante291 closed 2 months ago

Dante291 commented 2 months ago

What kind of change does this PR introduce?

This PR introduces enhancements to the organization information display by providing additional details about the organization and its address

Issue Number:

Fixes #2354

Did you add tests for your changes?

Yes

Snapshots/Videos:

https://github.com/PalisadoesFoundation/talawa/assets/103507835/c60d723d-fe44-4207-b689-de515f87382e

If relevant, did you update the documentation?

Yes

Does this PR introduce a breaking change?

Yes

Have you read the contributing guide?

Yes

github-actions[bot] commented 2 months ago

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if either of these two conditions occur:

  1. The overall code coverage drops below the target threshold of the repository
  2. Any file in the pull request has code coverage levels below the repository threshold

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

Do not assign reviewers. Our Queue Monitors will review your PR and assign them. When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

Other

:dart: Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.

Dante291 commented 2 months ago

@palisadoes @noman2002 org_info_screen.dart has more than 300 lines of code because it is a view file which contains UI logic so this can be ignored.

palisadoes commented 2 months ago

Please add it to the appropriate section of the pull request GitHub action file and include it in this PR

Dante291 commented 2 months ago

@palisadoes @noman2002 This is ready to be reviewed.

palisadoes commented 2 months ago

Please get the code coverage for the patch. The lib/widgets/custom_list_tile.dart file needs more attention.

image

image

Dante291 commented 2 months ago

Yup working on it.

Dante291 commented 2 months ago

@palisadoes CodeCov report didn't update...

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 98.15668% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 96.48%. Comparing base (05b89f4) to head (77e3654).

Files Patch % Lines
lib/widgets/organization_list.dart 0.00% 4 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #2478 +/- ## =========================================== + Coverage 96.42% 96.48% +0.06% =========================================== Files 152 154 +2 Lines 7588 7777 +189 =========================================== + Hits 7317 7504 +187 - Misses 271 273 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Dante291 commented 2 months ago

@noman2002 Please review, 4 lines are missing coverage because that file has 0 coverage also you have had this conversation for difficulty in writing test for this file.

Other than that I have written tests for all new lines or edited lines.