Closed Dante291 closed 2 months ago
We have these basic policies to make the approval process smoother for our volunteer team.
Please make sure your code passes all tests. Our test code coverage system will fail if either of these two conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.
Do not assign reviewers. Our Queue Monitors will review your PR and assign them. When your PR has been assigned reviewers contact them to get your code reviewed and approved via:
Your reviewer(s) will have the following roles:
:dart: Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.
@palisadoes @noman2002 org_info_screen.dart has more than 300 lines of code because it is a view file which contains UI logic so this can be ignored.
Please add it to the appropriate section of the pull request GitHub action file and include it in this PR
@palisadoes @noman2002 This is ready to be reviewed.
Please get the code coverage for the patch. The lib/widgets/custom_list_tile.dart file needs more attention.
Yup working on it.
@palisadoes CodeCov report didn't update...
Attention: Patch coverage is 98.15668%
with 4 lines
in your changes are missing coverage. Please review.
Project coverage is 96.48%. Comparing base (
05b89f4
) to head (77e3654
).
Files | Patch % | Lines |
---|---|---|
lib/widgets/organization_list.dart | 0.00% | 4 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
What kind of change does this PR introduce?
This PR introduces enhancements to the organization information display by providing additional details about the organization and its address
Issue Number:
Fixes #2354
Did you add tests for your changes?
Yes
Snapshots/Videos:
https://github.com/PalisadoesFoundation/talawa/assets/103507835/c60d723d-fe44-4207-b689-de515f87382e
If relevant, did you update the documentation?
Yes
Does this PR introduce a breaking change?
Yes
Have you read the contributing guide?
Yes