search

PalisadoesFoundation / talawa

Community Organization Management Software. Click on the link below to see our documentation.
https://docs.talawa.io/
GNU General Public License v3.0
306 stars 434 forks source link

Fixed loading indicator in Pinned Posts #2480

Closed GlenDsza closed 2 months ago

GlenDsza commented 2 months ago

What kind of change does this PR introduce?

bugfix

Issue Number:

Fixes #2391

Did you add tests for your changes?

Yes

Snapshots/Videos:

Summary

Does this PR introduce a breaking change?

No

Have you read the contributing guide?

Yes

github-actions[bot] commented 2 months ago

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if either of these two conditions occur:

  1. The overall code coverage drops below the target threshold of the repository
  2. Any file in the pull request has code coverage levels below the repository threshold

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

Do not assign reviewers. Our Queue Monitors will review your PR and assign them. When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

Other

:dart: Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.

palisadoes commented 2 months ago

Please fix the failing test

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.49%. Comparing base (2212d50) to head (b127bf1).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #2480 +/- ## ======================================== Coverage 96.48% 96.49% ======================================== Files 154 154 Lines 7777 7778 +1 ======================================== + Hits 7504 7505 +1 Misses 273 273 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

GlenDsza commented 2 months ago

Please fix the failing test

Done