PalisadoesFoundation / talawa

Community Organization Management Software. Click on the link below to see our documentation.
https://docs.talawa.io/
GNU General Public License v3.0
306 stars 434 forks source link

Fixed Error in Event Creation & Update with latest recurrence changes #2481

Closed GlenDsza closed 1 month ago

GlenDsza commented 2 months ago

What kind of change does this PR introduce?

bugfix, feature, refactoring

Issue Number:

Fixes #2468

Did you add tests for your changes?

Yes

Snapshots/Videos:

https://github.com/PalisadoesFoundation/talawa/assets/109027247/7f3718c6-00f2-4bc8-8d23-da7abf868110

Summary

Does this PR introduce a breaking change?

No.

Other information

No. of files changed is large as had to make minor changes in unrelated files due to generating new test_helper_mocks via mockito.

Have you read the contributing guide?

Yes

github-actions[bot] commented 2 months ago

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if either of these two conditions occur:

  1. The overall code coverage drops below the target threshold of the repository
  2. Any file in the pull request has code coverage levels below the repository threshold

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

Do not assign reviewers. Our Queue Monitors will review your PR and assign them. When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

Other

:dart: Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.

Cioppolo14 commented 2 months ago

@GlenDsza Please fix the failing test.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.61%. Comparing base (24f4aa7) to head (9e74a25).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #2481 +/- ## =========================================== + Coverage 96.50% 96.61% +0.11% =========================================== Files 154 155 +1 Lines 7777 7898 +121 =========================================== + Hits 7505 7631 +126 + Misses 272 267 -5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Dante291 commented 2 months ago

@GlenDsza Could you parse the date format into DD/MM/YYYY as that is more readable format and more user friendly also there is lot of space for date to be in a single line and not in multiple lines so please fix that too

image

palisadoes commented 2 months ago

Please also get the code test coverage higher

GlenDsza commented 2 months ago

Sorry for Delay, had exams past week, working on it (wip)