Closed GlenDsza closed 1 month ago
We have these basic policies to make the approval process smoother for our volunteer team.
Please make sure your code passes all tests. Our test code coverage system will fail if either of these two conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.
Do not assign reviewers. Our Queue Monitors will review your PR and assign them. When your PR has been assigned reviewers contact them to get your code reviewed and approved via:
Your reviewer(s) will have the following roles:
:dart: Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.
@GlenDsza Please fix the failing test.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 96.61%. Comparing base (
24f4aa7
) to head (9e74a25
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@GlenDsza Could you parse the date format into DD/MM/YYYY as that is more readable format and more user friendly also there is lot of space for date to be in a single line and not in multiple lines so please fix that too
Please also get the code test coverage higher
Sorry for Delay, had exams past week, working on it (wip)
What kind of change does this PR introduce?
bugfix, feature, refactoring
Issue Number:
Fixes #2468
Did you add tests for your changes?
Yes
Snapshots/Videos:
https://github.com/PalisadoesFoundation/talawa/assets/109027247/7f3718c6-00f2-4bc8-8d23-da7abf868110
Summary
Does this PR introduce a breaking change?
No.
Other information
No. of files changed is large as had to make minor changes in unrelated files due to generating new test_helper_mocks via mockito.
Have you read the contributing guide?
Yes