search

PalisadoesFoundation / talawa

Community Organization Management Software. Click on the link below to see our documentation.
https://docs.talawa.io/
GNU General Public License v3.0
306 stars 434 forks source link

Bug-Fix Image Picker (1.1.0) #2499

Closed ArinNigam closed 2 months ago

ArinNigam commented 2 months ago

What kind of change does this PR introduce?

Issue Number:

Fixes #2497

Did you add tests for your changes? No

Snapshots/Videos:

image image image

If relevant, did you update the documentation? No

Summary In the version 1.0.7 there was no argument limit but with the newer version 1.1.0 a newer argument has been added to two such methods of the image_picker package which was ultimately causing error of fewer named arguments. Hence I added a new parameter limit.

Does this PR introduce a breaking change? Yes, It fixes the dependabot issue for upgrading the package.

Have you read the contributing guide? Yes

github-actions[bot] commented 2 months ago

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if either of these two conditions occur:

  1. The overall code coverage drops below the target threshold of the repository
  2. Any file in the pull request has code coverage levels below the repository threshold

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

Do not assign reviewers. Our Queue Monitors will review your PR and assign them. When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

Other

:dart: Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.

ArinNigam commented 2 months ago

I am sorry I created a pull request to the main branch by mistake. I'll fix it