search

PalisadoesFoundation / talawa

Community Organization Management Software. Click on the link below to see our documentation.
https://docs.talawa.io/
GNU General Public License v3.0
306 stars 434 forks source link

Fix UI Theme issues in Light/Dark Mode #2501

Closed GlenDsza closed 1 month ago

GlenDsza commented 1 month ago

What kind of change does this PR introduce?

bugfix, refactoring

Issue Number:

Fixes #2487

Did you add tests for your changes?

Yes

Snapshots/Videos:

https://github.com/PalisadoesFoundation/talawa/assets/109027247/dcd05bb6-06a7-41c7-bcf4-911e4e0eecc9

Summary

Updated Color themes for various screens and components mentioned in issues such as Post Card, Login/Url Screen, Explore Events Appbar, etc.

Does this PR introduce a breaking change?

No

Other information

Have you read the contributing guide?

Yes

github-actions[bot] commented 1 month ago

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if either of these two conditions occur:

  1. The overall code coverage drops below the target threshold of the repository
  2. Any file in the pull request has code coverage levels below the repository threshold

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

Do not assign reviewers. Our Queue Monitors will review your PR and assign them. When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

Other

:dart: Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 98.68421% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 96.82%. Comparing base (55aa344) to head (635258d).

Files Patch % Lines
lib/widgets/post_widget.dart 97.05% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #2501 +/- ## =========================================== + Coverage 96.55% 96.82% +0.26% =========================================== Files 155 155 Lines 7898 7908 +10 =========================================== + Hits 7626 7657 +31 + Misses 272 251 -21 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

palisadoes commented 1 month ago

Please get the test coverage of the patch higher

GlenDsza commented 1 month ago

@palisadoes All tests are passing