Closed Azad99-9 closed 1 week ago
[!IMPORTANT]
Review skipped
Auto reviews are disabled on base/target branches other than the default branch.
Please check the settings in the CodeRabbit UI or the
.coderabbit.yaml
file in this repository. To trigger a single review, invoke the@coderabbitai review
command.You can disable this status message by setting the
reviews.review_status
tofalse
in the CodeRabbit configuration file.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
We have these basic policies to make the approval process smoother for our volunteer team.
Please make sure your code passes all tests. Our test code coverage system will fail if either of these two conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.
Do not assign reviewers. Our Queue Monitors will review your PR and assign them. When your PR has been assigned reviewers contact them to get your code reviewed and approved via:
Your reviewer(s) will have the following roles:
:dart: Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 96.85%. Comparing base (
fd3f777
) to head (09b2204
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This pull request did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please verify it has no conflicts with the develop branch and rebase if needed. Mention it now if you need help or give permission to other people to finish your work.
@noman2002, @DMills27 PTAL
What kind of change does this PR introduce?
This PR introduces a
ConnectivityService
into the code base. This service is responsible for detecting the network connectivity status of the mobile device.Issue Number:
Fixes #2520 Did you add tests for your changes?
Yes
Snapshots/Videos:
If relevant, did you update the documentation?
Summary
After merging this PR.
ConnectivityService
provides an API to access the connectivity status and trigger appropriate actions.ConnectivityService
uses theConnectivity_plus
package._handleOnline
, and_handleOffline
methods are intentionally left blank for future use.Does this PR introduce a breaking change?
No
Other information
This PR is just the business logic of the
offline detection mechanism
feature. The UI code to replicate the network changes and integrate this business logic will be raised in a subsequent PR within one week time.Have you read the contributing guide?
Yes