search

PalisadoesFoundation / talawa

Community Organization Management Software. Click on the link below to see our documentation.
https://docs.talawa.io/
GNU General Public License v3.0
338 stars 465 forks source link

Feat: Fundraising Campaigns (GSoC) #2635

Closed Dante291 closed 5 days ago

Dante291 commented 3 weeks ago

What kind of change does this PR introduce?

Adds supports for fund raising campaigns in Talawa mobile app

Issue Number:

Fixes #2593

Did you add tests for your changes?

Yes

Snapshots/Videos:

https://github.com/user-attachments/assets/10343d46-2cb0-43ab-8a5a-78a0fc014ba3

If relevant, did you update the documentation?

Yes

Summary

Does this PR introduce a breaking change?

Yes

Have you read the contributing guide?

Yes

Summary by CodeRabbit

Release Notes

coderabbitai[bot] commented 3 weeks ago

Walkthrough

The pull request introduces significant enhancements to fund management within the application. Key changes include the addition of new classes (Fund, Campaign, Pledge) and services (FundService, FundViewModel) to facilitate pledging and fundraising operations. The locator.dart file is updated for dependency injection of these new components. Additionally, various UI screens are implemented to display and manage funds, campaigns, and pledges, along with corresponding tests to ensure functionality. The changes aim to support features related to making pledges and donations.

Changes

File Change Summary
lib/locator.dart Added imports for FundService and FundViewModel, registered them for dependency injection.
lib/models/funds/fund.dart Introduced Fund class with properties and a fromJson factory method.
lib/models/funds/fund_campaign.dart Introduced Campaign class with properties and a fromJson factory method.
lib/models/funds/fund_pledges.dart Introduced Pledge class with properties and a fromJson factory method.
lib/services/event_service.dart Updated methods to use gqlAuthMutation for GraphQL operations.
lib/services/fund_service.dart Added FundService class with methods for managing funds, campaigns, and pledges.
lib/utils/fund_queries.dart Created FundQueries class for GraphQL queries and mutations related to funds.
lib/view_model/after_auth_view_models/funds_view_models/fund_view_model.dart Added FundViewModel class for managing fund-related data interactions.
lib/views/after_auth_screens/funds/fund_pledges_screen.dart Implemented PledgesScreen for managing pledges associated with a campaign.
lib/views/after_auth_screens/funds/fundraising_campaigns_screen.dart Implemented CampaignsScreen for displaying fundraising campaigns.
lib/views/after_auth_screens/funds/funds_screen.dart Implemented FundScreen for managing funds.
test/model_tests/funds/fund_campaign_test.dart Added unit tests for Campaign model.
test/model_tests/funds/fund_pledges_test.dart Added unit tests for Pledge model.
test/model_tests/funds/fund_test.dart Added unit tests for Fund model.
test/service_tests/fund_service_test.dart Added unit tests for FundService class.
test/utils/fund_queries_test.dart Added unit tests for FundQueries class.
test/view_model_tests/after_auth_view_model_tests/fund_view_models/fund_view_model_test.dart Added unit tests for FundViewModel class.
test/views/after_auth_screens/funds/fund_pledges_screen_test.dart Added widget tests for PledgesScreen.
test/views/after_auth_screens/funds/fund_screen_test.dart Added widget tests for FundScreen.
test/views/after_auth_screens/funds/fundraising_campaigns_screen_test.dart Added widget tests for CampaignsScreen.
test/widgets/add_pledge_dialogue_box_test.dart Added widget tests for AddPledgeDialog.
test/widgets/pledge_card_test.dart Added widget tests for PledgeCard.
test/widgets/update_pledge_dialogue_box_test.dart Added widget tests for UpdatePledgeDialog.
.github/workflows/pull-request.yml Updated workflow to exclude specific files from line counting.

Assessment against linked issues

Objective Addressed Explanation
Feature for making pledges/donation (#2593) ✅
Integration of fund management services (#2581) ✅

Suggested reviewers

🐇 In the fields of funds, we hop and play,
With pledges and campaigns, we brighten the day.
A new screen for pledges, a dialog to share,
Join us in giving, show that you care!
With every small hop, we gather our cheer,
For every donation, our mission is clear! 🌼💰

📜 Recent review details **Configuration used: .coderabbit.yaml** **Review profile: CHILL**
📥 Commits Reviewing files that changed from the base of the PR and between 9ab4f3026b29dddf6cd7731ded8c84c7810cc554 and d88dbb7f3fc841b9fe548216d59dfb20fce08c1d.
📒 Files selected for processing (1) * `.github/workflows/pull-request.yml` (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1) * .github/workflows/pull-request.yml

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### Documentation and Community - Visit our [Documentation](https://docs.coderabbit.ai) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
github-actions[bot] commented 3 weeks ago

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if either of these two conditions occur:

  1. The overall code coverage drops below the target threshold of the repository
  2. Any file in the pull request has code coverage levels below the repository threshold

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

Do not assign reviewers. Our Queue Monitors will review your PR and assign them. When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

Other

:dart: Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.

palisadoes commented 2 weeks ago

Please fix the failing tests.

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 91.22469% with 91 lines in your changes missing coverage. Please review.

Project coverage is 95.21%. Comparing base (48c349b) to head (d88dbb7). Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...view_models/funds_view_models/fund_view_model.dart 80.48% 24 Missing :warning:
lib/services/fund_service.dart 74.24% 17 Missing :warning:
.../after_auth_screens/funds/fund_pledges_screen.dart 91.53% 11 Missing :warning:
lib/services/image_service.dart 73.07% 7 Missing :warning:
...ews/after_auth_screens/feed/organization_feed.dart 50.00% 6 Missing :warning:
lib/widgets/update_pledge_dialogue_box.dart 96.07% 6 Missing :warning:
...b/views/after_auth_screens/funds/funds_screen.dart 95.72% 5 Missing :warning:
...th_screens/funds/fundraising_campaigns_screen.dart 96.87% 4 Missing :warning:
lib/widgets/add_pledge_dialogue_box.dart 97.36% 3 Missing :warning:
lib/widgets/agenda_item_tile.dart 0.00% 3 Missing :warning:
... and 5 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #2635 +/- ## =========================================== - Coverage 95.47% 95.21% -0.27% =========================================== Files 187 199 +12 Lines 9884 10909 +1025 =========================================== + Hits 9437 10387 +950 - Misses 447 522 +75 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚨 Try these New Features:

noman2002 commented 6 days ago

@Dante291 I am approving this but create issue for each file of this project which has missing test cases.