search

PalladioSimulator / Palladio-Editors-Sirius

Sirius-based editors for models of the Palladio Component Model (PCM).
Eclipse Public License 2.0
5 stars 4 forks source link

Stoex xtext editor #2

Closed larissaschmid closed 4 years ago

larissaschmid commented 5 years ago

Replaced old stoex dialog box with an xtext editor.

larissaschmid commented 5 years ago

I added a commit that removed the warnings and all usages of StochasticExpressionEditDialog. I cannot make StochasticExpressionEditDialog deprecated since it is located in the Palladio-Editors-Commons repo.

The moving behavior is the same for the standard direct edit labels in Sirius (e.g. MTTR) and is not specific for the StoexCellEditor. I did not have the case that the editing rectangle was drawn outside of the container but I suspect that this behavior also originates from the Sirius DirectEditLabel implementation.

larissaschmid commented 5 years ago

Since Sirius does not support showing error markers for semantic elements without a diagram representation, I added a customized validation that shows errors for those elements on their containers. When a RandomVariable is created or edited, a ResourceSetListener is attached to the TransactionalEditingDomain and runs the custom validation.

seiferma commented 4 years ago

This PR is blocked by PalladioSimulator/Palladio-Core-Commons#3. Besides from that, the code looks good and is ready to be merged.