search

Palm-Studios / sh3redux

SILENT HILL 3 Engine Remake in OpenGL and C++
GNU General Public License v3.0
164 stars 15 forks source link

Add input_system #101

Closed z33ky closed 7 years ago

z33ky commented 7 years ago

Ref #80.

Please review with scrutiny. As I've stated before, I ripped the code out of another project, so check that I properly adapted the naming conventions. I also changed some code, so check that I didn't miss updating the documentation.

Sadly the promised time-tracking is not possible with SDL, as mentioned in the documentation for INPUT_PROVIDE_TIMING in input_config.hpp.

This includes a separate test program with bindings for WASD, printing some stuff to stdout when pressing the keys. Before merging this I wish to adapt this into an automated test. We could still leave this version of the test included for documentation purposes.

z33ky commented 7 years ago

I still wanted to do the automated test thing, but no biggie, that'll just be a separate commit then.

More importantly, I forgot to tell you that this code depends on Boost (just the header-only part), which is also not added to the build system yet. Are you okay with that? I could get rid of it with some additional work.

Quaker762 commented 7 years ago

More importantly, I forgot to tell you that this code depends on Boost (just the header-only part), which is also not added to the build system yet. Are you okay with that? I could get rid of it with some additional work.

Nah it's okay, I'll just download the boost headers and libraries. Is there any reason to not use it?? The only reason I've heard is it's so big that it can bloat your binary, but that was a loooong time ago.

z33ky commented 7 years ago

Boost can be over-engineered for some use-cases, which can be noticeable mostly in compile-time. I think less so in run-time behavior, since it has high code quality and is tested in a variety of compilers and platforms. Sometimes I look for smaller alternatives to some of Boosts libs, but generally I like their stuff.