search

Palm-Studios / sh3redux

SILENT HILL 3 Engine Remake in OpenGL and C++
GNU General Public License v3.0
158 stars 15 forks source link

Silence most warnings #117

Closed z33ky closed 6 years ago

z33ky commented 6 years ago

With this PR, only -Weffc++ warnings remain for gcc (see #111) and spurious -Wdocumentation warnings (because it doesn't understand @see @ref Thing).

Quaker762 commented 6 years ago

This fixes most of the warnings except the ones that are GCC bugs as pointed out in #111 yes?

z33ky commented 6 years ago

All of the warnings, except for the -Weffc++ (gcc) and -Wdocumentation (clang) ones. I don't think the -Weffc++ warnings we get are bugs, they are just warnings about things that I don't think warrant changes. As stated in #111 though, this flag also warns about things that I think do warrant changes. The -Wdocumentation thing is a bug, because @see @ref Thing is certainly valid.