Palm-Studios / sh3redux

SILENT HILL 3 Engine Remake in OpenGL and C++
GNU General Public License v3.0
164 stars 15 forks source link

Change 'Open()' to public #129

Closed Quaker762 closed 6 years ago

Quaker762 commented 6 years ago

Moved the visibility of Open() to public. Certain objects in the future (maps etc) will need to have files in which the filename is determined at runtime, without forcing us to determine it at compile time.

@z33ky I had sh3 open in a debugger all day today and realised having Open() private is a horrible idea.. I'm not sure how it'll interfere with your resource manager, but I really think we'll need raw file handles for a lot of things, considering how the actual engine treats everything.

Quaker762 commented 6 years ago

This will not have any effect on my resource loady thingy.

I moreso meant that the engine seems to ID every file and correlates that with an offset that is then seeked in the raw file handle. Also some files are structured very strangely (as you can see in Mike's code). Though I suppose for some scene class we could have a bunch of the templated headers (I haven't seen the code so I don't quite know how it'll work haha :) )