Open andrewhowdencom opened 8 years ago
I'd certainly have nothing against a helm package, with the caveat that users still need to be able to configure their DNS provider somehow.
This is getting towards done (will tidy the history and write a decent commit later, but it's tracked at https://github.com/PalmStoneGames/kube-cert-manager/compare/master...andrewhowdencom:ahowden_add-helm-packge)
There are two outstanding issues:
This was verified in a number of ways
$ watch -n 1 netstat -tulpn
during a HTTP challenge requestStub (mental note) - A large, monolithic secret containing all environment variables is probably fine here.
@andrewhowdencom might be possible to do something cunning with named templates: https://github.com/kubernetes/helm/blob/master/docs/chart_template_guide/named_templates.md#the-include-function
Looks like all of these boilerplate env variables are of the form KEY=value
, so perhaps you can use something like the {{- range $key, $val := .Values.config }}
syntax at the bottom to only specify the env block once, and insert it N times, once for each k/v pair in the config dict.
You know, I completely forgot about this. I got it "mostly working", and have thus just been using it.
@paultiplady That is a good idea. However, I'm time limited -- given that this works as it stands, I might offer it up for PR shortly (so, with docs).
The helm charts have also undergone somewhat of a "standardisation" recently based around the prometheus chart, and have abstracted things like storage is a superior way.
For ref, the repo is here: https://github.com/andrewhowdencom/kube-cert-manager/tree/ahowden_add-helm-packge/helm
I don't have an internet connection that's reliable at the minute, but I'll see if I can take a look at this over the next couple weeks!
Thanks! Looking forward to the PR :)
Just saw this, I actually created a helm chart located here https://github.com/mirusresearch/charts/tree/master/incubator/kube-cert-manager Feel free to use it, pick it apart, submit PR
@AlecTroemel oh my god I forgot about this entirely, I feel so guilty. @luna-duclos the chart I previously constructed does not follow some of the more modern conventions set out by helm. I would probably vote for using @AlecTroemel's version, and as I get time to do work on this (I want to, but am currently under load setting up CI/CD pipelines with Kubernetes as well as some monitoring and logging infra) I will submit patches to @AlecTroemel's chart.
<3 Sorry all.
@andrewhowdencom no need to feel guilty, I just started using this awesome project! I hope to eventually commit some PR's to kube-cert-manager and merge that chart into the official helm repo.
Is there still work being done to get this into the official helm charts repo?
@rochdev I'm not sure. I created a helm chart you can use here https://github.com/mirusresearch/charts/tree/master/stable/kube-cert-manager. If its something the maintainers here want in the repo I could create a PR
This distribution seems like a good candidate to create a helm package from.
If you like, I will see if I can create a patch for this, somehow.