search

PalmStoneGames / kube-cert-manager

Manage Lets Encrypt certificates for a Kubernetes cluster.
Apache License 2.0
541 stars 102 forks source link

DNSimple v2 #56

Closed nanliu closed 7 years ago

nanliu commented 7 years ago

Looks like the current glide dependency uses the old DNSimple v1 API written by weppos. The lego repo have been updated to DNSimple official go library.

When I tried master, it seems to have issues with the token (verified working separately)

2017/04/19 00:23:21 Error while processing certificate event: Error while obtaining certificate for new domain [omitted]: Error presenting token: DNSimple API call failed: GET https://api.dnsimple.com/v1/domains: 401 Authentication failed

I think we can update glide, and replace DNSIMPLE_API_KEY with DNSIMPLE_OAUTH_TOKEN, however the requirement for DNSIMPLE_BASE_URL might be more annoying since it will require multiple kube-cert-manager per domain.

luna-duclos commented 7 years ago

Would updating the package actually be useful to DNSSIMPLE users ? It seems to me like xenolf/lego probably needs a way to pass in the baseURL and we need to support that

nanliu commented 7 years ago

Yes we should update to v2, because DNSimple is deprecating their v1 API, and it will be no longer available as of October 1st, 2017. We can pass the baseURL via environment variable.

luna-duclos commented 7 years ago

Closed by #57, thank you!

nanliu commented 7 years ago

PR #50 clobbered over #57, we are back to DNSimple v1.