Open ahmetb opened 7 years ago
Seems like you have to build your own containers for the latest version. I know there's discussion about moving this project to k8s incubator per #33, but happy to submit either a travis config that build/push to docker hub, or we can take advantage of docker hub build pipeline.
On a somewhat related note, we need git tags for all the versions in this repo. I can do git commit archeology, but wonder if someone who's used this project longer have a better idea?
@nanliu interesting. makes me wonder
deployment.yaml
if it never worked in the first place? that sounds like a guaranteed-to-fail installation experience.So, based on buildspec.yml git history: 0.5.0 aeaa115 (no idea where containers exist) 0.4.0 84bb913 whereisaaron/kube-cert-manager:0.4.0 Based on deployment.yml git history and docker inspect create timestamp of palmstonegames/kube-cert-manager 0.3.1 c779a05 0.3.0 7a5f64e 0.2.0 0cc027d 0.1.1 7f02012 0.1.0 502faa2
Please double check and tag repo if it's correct.
@ahmetb I have my own version that I built manually including some of the now-merged PRs. Looking forward to moving back to the upstream version once we work out where the project will end up.
@rosskukulinski that sounds like an independent discussion. Regardless of where this project ends up, there's no reason to tag releases on GitHub and set up simple Docker Hub builds based on git tags.
0.5.0 is the currently in development version, which is why it hasn't been tagged yet, this indeed needs to become much more clear from the documentation and will be looked at soonish
@luna-duclos perhaps a short term fix would be to fix the deployment.yaml with an image that works out of the box.
I've created tags up till 0.4.0, the next version I still consider unstable, hence why it wont' get a tag (yet), I've clarified this in the docs as well.
@luna-duclos, would you mind pushing 0.4.0 release to hub.docker.com?
I hadn't noticed it wasn't there, will do.
Tag 0.4.0 and 0.5.0 not available in docker hub
@luna-duclos Ping? 0.4.0 is still not available on Docker Hub.
Yep, still only showing up to 0.3.1: https://hub.docker.com/r/palmstonegames/kube-cert-manager/tags/
It's still only 0.3.1
that's available. You could also put 0.5.0
up there as 0.5.0-unstable
or 0.5.0-beta
.
We appreciate your work! But this kind of sucks.
Failed to pull image "palmstonegames/kube-cert-manager:0.5.0": rpc error: code = 2 desc = Error response from daemon: {"message":"manifest for palmstonegames/kube-cert-manager:0.5.0 not found"}
Error syncing pod
Followed instructions in deployment-guide.md
which references k8s/deployment.yaml
which references image palmstonegames/kube-cert-manager:0.5.0
.
In the meantime I pushed it to our dockerhub tagged with the git Sha https://hub.docker.com/r/iosphere/kube-cert-manager/
docker pull iosphere/kube-cert-manager:c8443d4
This is the current 0.5 version and uses Go 1.9. It still needs some CI setup
Is at least a 0.4.0 Docker Hub tag planned since this version was already released?
I anyone is interested, I have pushed in image to our repository:
iosphere/kube-cert-manager:5bba617
This contains the latest master commit 5bba617
with Go 1.9.2 and Alpine 3.7
Creating k8s/deployment.yaml gives error:
The tag doesn't seem to be there? https://hub.docker.com/r/palmstonegames/kube-cert-manager/tags/