search

Palmabit-IT / react-cookie-law

React Cookie Law is a cookie-info banner compliance with the GDPR and the EU cookie law. It allows the user to give consent in a granular way.
115 stars 55 forks source link

React should be a peer dependency instead of a dependency in package.json? #15

Open K3vinF opened 4 years ago

K3vinF commented 4 years ago

I see that React is listed as a dependency in package.json. It looks like this causes React code te be injected into the generated javascript in the /dist of the npm module. I don't think this is needed (nor desirable)?

I think it would be better to list React as a peer dependency?

asarzina commented 4 years ago

Yes, better. I'll move the dependency to the peer dependency with the next release. Thanks!