search

Palmabit-IT / react-cookie-law

React Cookie Law is a cookie-info banner compliance with the GDPR and the EU cookie law. It allows the user to give consent in a granular way.
115 stars 55 forks source link

Compilation issue #27

Closed chriskaya closed 3 years ago

chriskaya commented 3 years ago

Hi,

First of all, thank you for your work, it seems to be exactly what I need :) I'm having an issue at startup:

./node_modules/@palmabit/react-cookie-law/dist/index.js
Cannot find file: 'index.js' does not match the corresponding name on disk: '.\node_modules\React\react'.

I'm using v0.6.1, on windows (git bash).

It seems to be caused by 2 require('React') in dist/index.js (works with require('react')). It might be related to this addition in webpack.config.js commit 4ce11ca3874c9ec5cc5ce9f235e68e542dbe5259:

  externals: {
    react: 'React',
  },

Could you have a look please? :)

Edit: confirmed on my side, I created a PR: #28

asarzina commented 3 years ago

Merged, thanks!

chriskaya commented 3 years ago

You're welcome :)