search

PaloAltoNetworks / ansible-pan

Ansible modules for Palo Alto Networks NGFWs
Other
229 stars 161 forks source link

panos_interface: do not add aggregate-group interface on virtual_router #424

Closed odysseus107 closed 5 years ago

odysseus107 commented 5 years ago

fix to not add interface to virtual router if it is an aggregate-group assignment

perhaps a few more interface types have to be ignored for virtual router?!?

fixes https://github.com/PaloAltoNetworks/ansible-pan/issues/421

shinmog commented 5 years ago

@odysseus107

This kind of code should really be in pandevice, not the Ansible modules. If you look at set_vsys() you see that this is handled there.

Could you open a PR against pandevice's set_virtual_router() and close this one?

odysseus107 commented 5 years ago

@shinmog

Thanks for the hints. Here is the requested pull request: https://github.com/PaloAltoNetworks/pandevice/pull/174