search

PaloAltoNetworks / azure-autoscaling

Azure autoscaling solution using VMSS
17 stars 39 forks source link

infra and inbound script bugs #4

Open pstajewski opened 3 years ago

pstajewski commented 3 years ago

Describe the bug

  1. The infra script has "East US" hard coded for appinsight.
  2. The inbound script will not deploy to an existing vnet, if the existing vnet is a in a different resource group than the firewalls. It will also deploy appinsight to East US, and not to the region selected.

Expected behavior

  1. appinsight should be deployed to the region selected
  2. inbound script should be capable of deploying to a vnet that exists in different resource group, this is a very common scenario

Current behavior

  1. As described above, appinsight for infra script will always deploy in "East US", no matter what region is selected
  2. If existing vnet option is selected for deployment, and the existing vnet is in a different resource group the deployment fails during vnet execution

Possible solution

  1. Update the infra script with a region variable selected, rather then having the region hardcoded
  2. I believe the inbound script fails because if vnet exists in a different resource group you must specify what that resource group is, and the current script does not allow for that. It tries to deploy to the region selected for the firewalls

Steps to reproduce

  1. Execute infra script and select region any other then East US
  2. Build a vnet with subnets that exists in a different resource groups to where the firewalls will be. Execute inbound script, create new resource group, and attempt to deploy to existing vnet previously created
welcome[bot] commented 3 years ago

:tada: Thanks for opening your first issue here! Welcome to the community!