Allow setting storageClassName in .Values - Githubissues

PaloAltoNetworks / cn-series-helm

This repo is for deploying CN-series firewall using Helm Package Manager for Kubernetes

MIT License

13 stars 22 forks source link

Allow setting storageClassName in .Values #17

Open DanFathom5 opened 3 years ago

DanFathom5 commented 3 years ago

Description

Adds a .Values.storageClassName, which is then used to override the pan-local-storage/manual hardcoded values.

Motivation and Context

Allows users to specify their own storage classes. For example, to use longhorn.

How Has This Been Tested?

I ran it in my cluster and was able to get longhorn to provision the volumes.

Types of changes

New feature (non-breaking change which adds functionality)

Checklist

[x] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes if appropriate.
[x] All new and existing tests passed.

DanFathom5 commented 3 years ago

I admittedly still do not understand what the idea is behind "manual" and "pan-local-storage", but, with this PR, the values will default to their state, so no changes will happen unless one specifically enables the override by setting storageClassName. This PR allows one to simply override that default behavior.