search

PaloAltoNetworks / iron-skillet

IronSkillet is a set of day-one configuration templates for PAN-OS to enable alignment with security best practices. See the Quick Start section below to get started using the template configurations.
MIT License
200 stars 104 forks source link

"Recommended_Decryption_Profile protocol settings max version is TLS 1.3 or max" link takes user to URL Filtering docs, not Decryption docs #123

Closed wegotourselvesareader closed 3 years ago

wegotourselvesareader commented 3 years ago

Describe the bug

One of the tests in the "IronSkillet - check NGFW config for updated v10.1 elements" skillet is for the SSL Decryption protocol version.

The text in the test result is a clickable hyperlink which takes the user to some online documentation, but the wrong documentation.

It takes the user to https://iron-skillet.readthedocs.io/en/docs_master/viz_guide_panos.html#url-filtering

It should take the user to https://iron-skillet.readthedocs.io/en/docs_master/viz_guide_panos.html#decryption-profile

Panhandler_wrong_hyperlink

BoraMutluoglu commented 3 years ago

@morrisalex Hello and thanks for reporting this bug, I will look into fixing this ASAP.

BoraMutluoglu commented 3 years ago

@morrisalex Issue should be fixed, updated the documentation link and tested locally. Issue should be fixed after updating the IronSkillet repo in PanHandler. Please let me know if the issue still persists on your side.

wegotourselvesareader commented 3 years ago

Updated and tested. Looks good. Thank you.