search

PaloAltoNetworks / iron-skillet

IronSkillet is a set of day-one configuration templates for PAN-OS to enable alignment with security best practices. See the Quick Start section below to get started using the template configurations.
MIT License
200 stars 104 forks source link

Panhandler reports failed check for time zone, with "Etc/UTC" #136

Closed wegotourselvesareader closed 3 years ago

wegotourselvesareader commented 3 years ago

Describe the bug

Similar to https://github.com/PaloAltoNetworks/iron-skillet/issues/118 Panhandler appears to be looking for a single specific value for a setting, where more than one value may be appropriate.

Panhandler reports a failure if the firewall's timezone is not "UTC". However, many systems use the recognised standard "Etc/UTC", which is also supported by PAN-OS.

See ftp://ftp.iana.org/tz/data/ for further details on the available timezone names in the tz database

Expected behavior

Panhandler / Iron Skillet should allow for multiple equivalent values, where appropriate.

Current behavior

Panhandler / Iron Skillet checks for a single specific value.

Possible solution

Suggest updating Panhandler / Iron Skillet to accommodate multiple equally-valid options for the time zone.

Steps to reproduce

  1. Set the firewall's timezone to Etc/UTC.
  2. Run an Iron Skillet check against the firewall
  3. Observe the timezone failure in the report.

Screenshots

Firewall: image

Panhandler: image

Your Environment

BoraMutluoglu commented 3 years ago

Hello, I will take a look into this issue and get back to you with updates. Thank you for reporting it.

BoraMutluoglu commented 3 years ago

Issue has been fixed. Closing out.

wegotourselvesareader commented 3 years ago

Updated the skillet repository inside Panhandler and ran the check again. This time it passes successfully. Many thanks for fixing it.