search

PaloAltoNetworks / minemeld-core

Engine of MineMeld
Apache License 2.0
141 stars 95 forks source link

Add type to indicators other than IPs for Recorded Future miner #377

Closed christian-recordedfuture closed 3 years ago

christian-recordedfuture commented 3 years ago

Description

Added 'type' to domains, file hashes and URLs.

Motivation and Context

It created problems for at least one of our customers to not have the type set for domains. Since we were already doing changes to the code it felt sane to add types for other indicators as well.

How Has This Been Tested?

This was tested by running minemeld in a docker container and pulling 5 different risk lists from the Recorded Future system. One for each indicator type using the MasterRiskList class and verifying that the type was set in a few indicators per risk list.

Types of changes

jtschichold commented 3 years ago

Hi @christian-recordedfuture, thanks for the PR and for the fixes. Please could you target the devel branch instead of master?

Thanks, Luigi

christian-recordedfuture commented 3 years ago

@jtschichold I changed the target. There was two different devel branches, but I chose the one without a version number. I hope this was right.

jtschichold commented 3 years ago

Could you check #378? I have opened it with your changes to have a clean merge.

Thanks