search

PaloAltoNetworks / minemeld

Main MineMeld documentation repo
380 stars 64 forks source link

Python3 support? #50

Open mnooseman opened 4 years ago

mnooseman commented 4 years ago

Python 2.7 is End of life and many distributions will be dropping it (if they haven't already)

Is there a plan to update minemeld to allow Python3? As it stands on Ubuntu 18.04 fully patched, minemeld-ansible doesn't work because of issues with ujson (which itself hasn't been updated in 3 years)

Anything newer than 18.04 will not have Python 2.7 by default (checked on 19.10 and 20.04 pre-release.)

mnooseman commented 4 years ago

I've done some initial looking by running the minemeld-core repo through futurize... Other than a very few changes (mostly errant print statements using the py2 style, and I believe 1 use of the raise statement that isn't compatible) the code base is entirely Py3 compatible.. This wouldn't take very much to transition entirely to Py3.

I may submit a PR for the changes, but it seems that PRs here don't get picked up often? Is the develop branch and master branch setup properly (like can I submit a PR against develop and not miss anything thats only in master?)

jtschichold commented 4 years ago

Hi @mnooseman, we can talk more about it on Slack. But yes, going forward we should plan to:

I already did some exploratory work on porting to py3 in the past: https://github.com/jtschichold/minemeld-core/tree/feature/python3