PaloAltoNetworks / pan-os-php

Framework and utilities to easily manage and edit Palo Alto Network PANOS devices
ISC License
73 stars 16 forks source link

Rule-Marker.php Undefined variable $configOutput #756

Closed davis-sean closed 1 year ago

davis-sean commented 1 year ago

Describe the bug

Rule-marker.php from the AppID-Toolbox fails to run - indicating a undefined variable.

Died on user notice or warning!! Error: Undefined variable $configOutput on /tools/pan-os-php/appid-toolbox/lib/common.php:654

Expected behavior

AppID toolbox runs and marks rules for AppID migration.

Current behavior

Toolbox fails to run with error.

Possible solution

Define $configOutput variable at beginning of function.

Steps to reproduce

  1. pan-os-php type=appid-toolbox phase=rule-marker in=api://FIREWALL location=vsys1

Screenshots

image

Context

AppID Migration.

Your Environment

Single vsys firewall - using Docker image of pan-os-php

welcome-to-palo-alto-networks[bot] commented 1 year ago

:tada: Thanks for opening your first issue here! Welcome to the community!

swaschkut commented 1 year ago

hi davis-sean, thanks for finding and reporting this issue;

there is just a fix published in the develop Docker container,

would be good if you can validate on your side if this is fixing your problem:

docker run --name panosphp --rm -v ${PWD}:/share -it swaschkut/pan-os-php:develop

EDIT: please give hub.docker.com some more minutes :-)

davis-sean commented 1 year ago

Hello, It looks like the issue is still there:

Error_PAN-OS-PHP

swaschkut commented 1 year ago

sorry, yes. still having problems with hub.docker.com to publish the correct container. I will update again, as soon as this is correctly published

swaschkut commented 1 year ago

please check

swaschkut commented 1 year ago

bug fixed in the actual develop version;

docker run --name panosphp --rm -v ${PWD}:/share -it swaschkut/pan-os-php:develop

https://github.com/swaschkut/pan-os-php

will be published latest by end of this week

davis-sean commented 1 year ago

The fix appears to have worked. The marking phase went off without issue this time.

swaschkut commented 1 year ago

bugfix published with #757