search

PaloAltoNetworks / pan-os-python

The PAN-OS SDK for Python is a package to help interact with Palo Alto Networks devices (including physical and virtualized Next-generation Firewalls and Panorama). The pan-os-python SDK is object oriented and mimics the traditional interaction with the device via the GUI or CLI/API.
https://pan-os-python.readthedocs.io
ISC License
345 stars 170 forks source link

fix: PanoramaCommitAll - False args ignored #338

Closed btorresgil closed 3 years ago

btorresgil commented 3 years ago

Fixes #332 Fixes PaloAltoNetworks/pan-os-ansible#204

shinmog commented 3 years ago

These two are "lazy" in that they only show up if the value is True because these aren't present in older versions of PAN-OS, so setting them globally will break backwards compatibility. I have not researched when it showed up, so I don't know. The versions might be EOL at this point, so maybe not an issue..?

Regardless, should probably be panos.yesno()ing their inclusion in the commit XML.

btorresgil commented 3 years ago

The way I changed it, there are 3 options:

None (default): nothing is added to the XML. True: yes is added to XML. False: no is added to XML.

So this should not affect versions where these features don't exist, because you can use None.

github-actions[bot] commented 3 years ago

:tada: This PR is included in version 1.1.1 :tada:

The release is available on PyPI and GitHub release

Posted by semantic-release bot