PaloAltoNetworks / pan-os-python

The PAN-OS SDK for Python is a package to help interact with Palo Alto Networks devices (including physical and virtualized Next-generation Firewalls and Panorama). The pan-os-python SDK is object oriented and mimics the traditional interaction with the device via the GUI or CLI/API.
https://pan-os-python.readthedocs.io
ISC License
345 stars 170 forks source link

Decryption Policy Class Wrong Xpath #431

Closed Kshehata1990 closed 2 years ago

Kshehata1990 commented 2 years ago

{I think the xpath in decryption profile is wrong should be /decryption/rules NOT /pbf/rules }

class DecryptionRule(VersionedPanObject):

SUFFIX = ENTRY
ROOT = Root.VSYS
HIT_COUNT_STYLE = "decryption"

bug in decryption policy class.odt

def _setup(self):
    # xpaths
    self._xpaths.add_profile(value="/pbf/rules")  <<<<<  _{I think the xpath here should be /decryption/rules  NOT /pbf/rules }_

    # params
    params = []

    params.append(VersionedParamPath("descrip

bug in decryption policy class.odt tion", path="description")) params.append(VersionedParamPath("uuid", exclude=True)) params[-1].add_profile("9.0.0", vartype="attrib", path="uuid") params.append( VersionedParamPath("source_zones", vartype="member", path="from",) )

welcome-to-palo-alto-networks[bot] commented 2 years ago

:tada: Thanks for opening your first issue here! Welcome to the community!

shinmog commented 2 years ago

This was fixed in #404 but it hasn't been released yet