fix: `delete_similar()` now breaks delete calls into chunks

PaloAltoNetworks / pan-os-python

The PAN-OS SDK for Python is a package to help interact with Palo Alto Networks devices (including physical and virtualized Next-generation Firewalls and Panorama). The pan-os-python SDK is object oriented and mimics the traditional interaction with the device via the GUI or CLI/API.

https://pan-os-python.readthedocs.io

ISC License

341 stars 169 forks source link

fix: `delete_similar()` now breaks delete calls into chunks #435

Closed shinmog closed 2 years ago

shinmog commented 2 years ago

Some testing of PAN-OS responsiveness has lead to the discovery that a delete() API call of around 25k characters can take anywhere from 3.3sec to 15sec, depending on the load. All pan-os-python API calls are expected to complete within 30sec by default. If the API call takes longer than that to complete, then the call times out and the delete doesn't seem to take.

Thus, delete_similar() will now break deletes into chunks of around 25k characters.

github-actions[bot] commented 2 years ago

:tada: This PR is included in version 1.7.0 :tada:

The release is available on PyPI and GitHub release

Posted by semantic-release bot