PaloAltoNetworks / pan-os-python

The PAN-OS SDK for Python is a package to help interact with Palo Alto Networks devices (including physical and virtualized Next-generation Firewalls and Panorama). The pan-os-python SDK is object oriented and mimics the traditional interaction with the device via the GUI or CLI/API.
https://pan-os-python.readthedocs.io
ISC License
340 stars 168 forks source link

Fix formatting of `request system software install` command - load_config parameter #447

Closed FoSix closed 2 years ago

FoSix commented 2 years ago

Description

The command triggered in SoftwareUpdater.install() method has wrong formatting around load_config parameter. All non key words should be quoted, this includes the value of load_config (see op method documentation).

For the moment the load_config parameter is not quoted which causes the op method to fail.

Motivation and Context

W/o this fix running an upgrade with named configuration load after reboot is not possible.

How Has This Been Tested?

This fix was used in an Ansible playbook.

Screenshots (if appropriate)

Types of changes

Checklist

welcome-to-palo-alto-networks[bot] commented 2 years ago

:tada: Thanks for opening this pull request! We really appreciate contributors like you! :raised_hands:

welcome-to-palo-alto-networks[bot] commented 2 years ago

:tada: Congrats on getting your first pull request merged! We here at Palo Alto Networks are so grateful! :heart:

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 1.8.0 :tada:

The release is available on PyPI and GitHub release

Posted by semantic-release bot