search

PaloAltoNetworks / pan-os-python

The PAN-OS SDK for Python is a package to help interact with Palo Alto Networks devices (including physical and virtualized Next-generation Firewalls and Panorama). The pan-os-python SDK is object oriented and mimics the traditional interaction with the device via the GUI or CLI/API.
https://pan-os-python.readthedocs.io
ISC License
347 stars 172 forks source link

Add additional resources to show_system_resources #544

Closed keithcampbelljr closed 9 months ago

keithcampbelljr commented 10 months ago

Description

Added additional system resources to the output when calling the method show_system_resources per the enhancement issue linked below.

Motivation and Context

Issue: https://github.com/PaloAltoNetworks/pan-os-python/issues/478

How Has This Been Tested?

I have a lab environment running Panorama and Palo Alto VM Series endpoints. To test the changes I made the update to my venv with the new block of code and updated regex. I ran the method and printed the return value. This included the mem_used and buffer memory used values I was expecting. Verified this by connecting to the Panorama endpoint and running a show system resources command.

Screenshots (if appropriate)

image

Types of changes

Checklist

shinmog commented 9 months ago

need to address the code formatting issue

keithcampbelljr commented 9 months ago

@shinmog Thanks for the feedback, went ahead and fixed the format issue. Must have missed it when running tests locally.