added new_appid to allowed parameters for ApplicationFilter. Need to … - Githubissues

PaloAltoNetworks / pan-os-python

The PAN-OS SDK for Python is a package to help interact with Palo Alto Networks devices (including physical and virtualized Next-generation Firewalls and Panorama). The pan-os-python SDK is object oriented and mimics the traditional interaction with the device via the GUI or CLI/API.

https://pan-os-python.readthedocs.io

ISC License

344 stars 170 forks source link

added new_appid to allowed parameters for ApplicationFilter. Need to … #547

Closed keithcampbelljr closed 8 months ago

keithcampbelljr commented 8 months ago

Description

Pep8 formattin Added additional parameter for applicationfilter class to allow for "Apply to New App-IDs only"

Motivation and Context

https://github.com/PaloAltoNetworks/pan-os-python/issues/522 https://github.com/PaloAltoNetworks/pan-os-python/issues/518

How Has This Been Tested?

Tested against Panorama lab environment, verified filter created and had the correct "Apply to New App-IDs only" check box checked.

Screenshots (if appropriate)

N/A

Types of changes

New feature (non-breaking change which adds functionality)

Checklist

[X ] I have updated the documentation accordingly.
[X ] I have read the CONTRIBUTING document.
[X ] I have added tests to cover my changes if appropriate.
[X ] All new and existing tests passed.

shinmog commented 8 months ago

formatting needs to be addressed

keithcampbelljr commented 8 months ago

@shinmog Hey! I managed to get formatting to pass. I have an extension 'auto pep8' which was causing the silly issue. Should be clear now :)

Might have another PR this evening for another issue.