added 'baseUrl' to environment file

jcallowaypanw commented 2 years ago

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate)

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes if appropriate.
[ ] All new and existing tests passed.

welcome-to-palo-alto-networks[bot] commented 2 years ago

:tada: Thanks for opening this pull request! We really appreciate contributors like you! :raised_hands:

jcallowaypanw commented 2 years ago

Approved

sullivan1337 commented 2 years ago

@jcallowaypanw what is the use of the baseUrl in the env?

jcallowaypanw commented 2 years ago

baseURL is the path for the console. You get it in Compute > Manage > Utilities > Path to Console. Hope this helps!

On Wed, Aug 24, 2022 at 10:50 AM sullivan1337 @.***> wrote:

@jcallowaypanw https://urldefense.com/v3/__https://github.com/jcallowaypanw__;!!Mt_FR42WkD9csi9Y!bGlXC9k1lToEoXyt6szLwGlDOpbBGvpE4NAZ1pZDW5EwLC0v-SSBWjnCRlYtyrCaHgnvkz0vpANXLuena9YPuSp43GDgSqS51A$ what is the use of the baseUrl in the env?

— Reply to this email directly, view it on GitHub https://urldefense.com/v3/__https://github.com/PaloAltoNetworks/pcs-postman/pull/17*issuecomment-1225832829__;Iw!!Mt_FR42WkD9csi9Y!bGlXC9k1lToEoXyt6szLwGlDOpbBGvpE4NAZ1pZDW5EwLC0v-SSBWjnCRlYtyrCaHgnvkz0vpANXLuena9YPuSp43GAG_14oWg$, or unsubscribe https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AX5KTVMC7ZTL3BPP7S2H4A3V2YZCRANCNFSM54WJEJNA__;!!Mt_FR42WkD9csi9Y!bGlXC9k1lToEoXyt6szLwGlDOpbBGvpE4NAZ1pZDW5EwLC0v-SSBWjnCRlYtyrCaHgnvkz0vpANXLuena9YPuSp43GC29yGoYw$ . You are receiving this because you were mentioned.Message ID: @.***>

--

Jonathan Calloway | Extended Expertise Consultant

Palo Alto Networks | 3000 Tannery Way | Santa Clara, CA 95054 | USA

Mobile: 423.309.2547 | www.paloaltonetworks.com https://www.paloaltonetworks.com/

https://www.paloaltonetworks.com/prisma https://www.linkedin.com/company/palo-alto-networks https://www.facebook.com/PaloAltoNetworks/ https://twitter.com/PaloAltoNtwks

The content of this message is the proprietary and confidential property of Palo Alto Networks, and should be treated as such. If you are not the intended recipient and have received this message in error, please delete this message from your computer system and notify me immediately by reply e-mail. Any unauthorized use or distribution of the content of this message is prohibited.

sullivan1337 commented 2 years ago

This is already there as

{
    "key": "compute-api-endpoint",
    "value": "https://us-east1.cloud.twistlock.com/us-1-123456789",
    "enabled": true
}

jcallowaypanw commented 2 years ago

Yep! Was there something else you needed to know about it?

On Wed, Aug 24, 2022 at 11:24 AM sullivan1337 @.***> wrote:

This is already there as

{ "key": "compute-api-endpoint", "value": "https://us-east1.cloud.twistlock.com/us-1-123456789 https://urldefense.com/v3/__https://us-east1.cloud.twistlock.com/us-1-123456789__;!!Mt_FR42WkD9csi9Y!aWjH7X3FIYf8PtAmmXUgK9AiHFBAYx6HR6s99ooewYfs0-v0AI9_fRmWzc4eWfJ4qEuTS-fZQOLGjI7Qxh1lb2ghnA9OGOC62A$", "enabled": true }

— Reply to this email directly, view it on GitHub https://urldefense.com/v3/__https://github.com/PaloAltoNetworks/pcs-postman/pull/17*issuecomment-1225876032__;Iw!!Mt_FR42WkD9csi9Y!aWjH7X3FIYf8PtAmmXUgK9AiHFBAYx6HR6s99ooewYfs0-v0AI9_fRmWzc4eWfJ4qEuTS-fZQOLGjI7Qxh1lb2ghnA8pRW5dkQ$, or unsubscribe https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AX5KTVOVTONBYOCTY2A76OLV2Y5DNANCNFSM54WJEJNA__;!!Mt_FR42WkD9csi9Y!aWjH7X3FIYf8PtAmmXUgK9AiHFBAYx6HR6s99ooewYfs0-v0AI9_fRmWzc4eWfJ4qEuTS-fZQOLGjI7Qxh1lb2ghnA_lZ2SwWQ$ . You are receiving this because you were mentioned.Message ID: @.***>

--

Jonathan Calloway | Extended Expertise Consultant

Palo Alto Networks | 3000 Tannery Way | Santa Clara, CA 95054 | USA

Mobile: 423.309.2547 | www.paloaltonetworks.com https://www.paloaltonetworks.com/

https://www.paloaltonetworks.com/prisma https://www.linkedin.com/company/palo-alto-networks https://www.facebook.com/PaloAltoNetworks/ https://twitter.com/PaloAltoNtwks

The content of this message is the proprietary and confidential property of Palo Alto Networks, and should be treated as such. If you are not the intended recipient and have received this message in error, please delete this message from your computer system and notify me immediately by reply e-mail. Any unauthorized use or distribution of the content of this message is prohibited.

tommynsong commented 1 year ago

@jcallowaypanw the purpose of baseUrl is already fulfilled by compute-api-endpoint, do we necessarily need 2 keys to carry the same value?

pan0ptic0n commented 1 year ago

Closing this PR unmerged; there is no value added with this additional key.

PaloAltoNetworks / pcs-postman