PaloAltoNetworks / pcs-sizing-scripts

Prisma Cloud sizing scripts
ISC License
46 stars 49 forks source link

refactor with ShellCheck, query for Regions, add Application ELBs #1

Closed tkishel closed 3 years ago

tkishel commented 3 years ago

Description

Refactor with ShellCheck (https://www.shellcheck.net) Query for AWS Regions, with a fallback default Add Application ELBs

Motivation and Context

ShellCheck tests for bugs and best practices Hardcoding regions creates accuracy and maintenance issues (still present in defaults) Application ELBs are billable resources

How Has This Been Tested?

ShellCheck Tested on the command-line with valid AWS credentials

Types of changes

Checklist

tkishel commented 3 years ago

Done!