PaloAltoNetworks / pcs-sizing-scripts

Prisma Cloud sizing scripts
ISC License
46 stars 49 forks source link

Updating the script to support bare metal VM and network load balancer in OCI cloud #22

Closed LSubbiahPanw closed 2 years ago

LSubbiahPanw commented 2 years ago

Description

Extending billable resource calculation to be done for two new resources in OCI

Motivation and Context

We are bringing up new two resources in OCI, bare metal vm database and network load balancers

How Has This Been Tested?

Screenshots (if appropriate)

Types of changes

Checklist

welcome-to-palo-alto-networks[bot] commented 2 years ago

:tada: Thanks for opening this pull request! We really appreciate contributors like you! :raised_hands:

tkishel commented 2 years ago

LGTM.

In the future, if you could add test payloads and use them to test the math in:

https://github.com/PaloAltoNetworks/pcs-sizing-scripts/blob/main/spec/resource-count-oci_spec.sh

that would be great!

welcome-to-palo-alto-networks[bot] commented 2 years ago

:tada: Congrats on getting your first pull request merged! We here at Palo Alto Networks are so grateful! :heart: