PaloAltoNetworks / pcs-sizing-scripts

Prisma Cloud sizing scripts
ISC License
46 stars 49 forks source link

Support for ELBv2 #43

Closed bralmeidapan closed 1 year ago

bralmeidapan commented 2 years ago

Is your feature request related to a problem?

It seems we are only checking for elb, and not including elbv2 as part of our API queries.

Describe the solution you'd like

I would like us to include support for aws elbv2 describe-load-balancers.

Describe alternatives you've considered

Asking the client for how many ELBs they are using.

Additional context

This issue was identified by a client during a PoC. They ran the script, and it returned zero for the ELB service. However, the client knows that they have several ELBs.

welcome-to-palo-alto-networks[bot] commented 2 years ago

:tada: Thanks for opening your first issue here! Welcome to the community!

tkishel commented 2 years ago

Hello Bruno, have you verified whether ELBv2 resources count towards credit consumption?

Our documentation only states ELB ...

https://www.paloaltonetworks.com/resources/guides/prisma-cloud-enterprise-edition-licensing-guide

bmppa commented 1 year ago

hi @tkishel, it looks like ELBv2 resources don't count towards credit consumption.

tkishel commented 1 year ago

Thanks for following up! Product engineering is "aware" of these scripts and have updated us in the past when what we count changes. Hopefully that continues.