search

PaloAltoNetworks / pcs-sizing-scripts

Prisma Cloud sizing scripts
ISC License
46 stars 49 forks source link

Please can we have resource counts for ELBs and EKS clusters? #48

Open dedayosam opened 1 year ago

dedayosam commented 1 year ago

Please can we have resource counts for ELBs and EKS clusters?

I see code for listing the EKS clusters in the resource-count-aws.sh script but no flag for it. Same for the ELBs as well.

Thank you.

welcome-to-palo-alto-networks[bot] commented 1 year ago

:tada: Thanks for opening your first issue here! Welcome to the community!

tkishel commented 1 year ago

If cwp is specified as a parameter:

https://github.com/PaloAltoNetworks/pcs-sizing-scripts/blob/main/aws/resource-count-aws.sh#L56

We do count EKS clusters:

https://github.com/PaloAltoNetworks/pcs-sizing-scripts/blob/main/aws/resource-count-aws.sh#L528

https://github.com/PaloAltoNetworks/pcs-sizing-scripts/blob/main/aws/resource-count-aws.sh#L259

https://github.com/PaloAltoNetworks/pcs-sizing-scripts/blob/main/aws/resource-count-aws.sh#L498

And we always count ELBs:

https://github.com/PaloAltoNetworks/pcs-sizing-scripts/blob/main/aws/resource-count-aws.sh#L259

You can verify this by adding -x to line 1 and running.

https://superuser.com/questions/1537905/what-does-x-mean-in-this-line-bin-sh-x#:~:text=What%20x%20mean%20in%20the,entire%20script%20in%20debug%20mode.