Add cluster name feature

hi-artem commented 2 years ago

Description

Add cluster parameter to defenderConfig to allow specifying names from clusters where name can't be auto-discovered.

Motivation and Context

In our case, we run EKS cluster with blocked metadata api and want to have a way to manually specify name.

How Has This Been Tested?

Tested with the following Defender config:

apiVersion: pcc.paloaltonetworks.com/v1alpha1
kind: Defender
metadata:
  name: pcc-defender
  namespace: twistlock
spec:
  namespace: twistlock
  orchestrator: kubernetes
  version: '21_08_525'
  defenderConfig:
    cluster: test-cluster
    clusterAddress: example.com
    consoleAddress: https://example.com

Types of changes

New feature (non-breaking change which adds functionality)

Checklist

[x] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes if appropriate.
[ ] All new and existing tests passed.

welcome-to-palo-alto-networks[bot] commented 2 years ago

:tada: Thanks for opening this pull request! We really appreciate contributors like you! :raised_hands:

hi-artem commented 2 years ago

@wfg can you help me with getting this one merged. it is currently blocking us from using upstream operator.

wfg commented 2 years ago

Were you able to test this? Everything worked as expected I assume.

hi-artem commented 2 years ago

Yep. We have been running operator with these changes in our cluster without any observable issues.

wfg commented 2 years ago

awesome. I'll merge now. I'll have to create PRs in the upstream repos to get a new version published.

welcome-to-palo-alto-networks[bot] commented 2 years ago

:tada: Congrats on getting your first pull request merged! We here at Palo Alto Networks are so grateful! :heart:

hi-artem commented 2 years ago

sounds good! thank you

PaloAltoNetworks / prisma-cloud-compute-operator