feature: custom Docker host support - Githubissues

PaloAltoNetworks / prisma-cloud-scan

GitHub action to scan container images with Palo Alto Networks' Prisma Cloud

Apache License 2.0

48 stars 41 forks source link

feature: custom Docker host support #14

Closed thecanadianroot closed 2 years ago

thecanadianroot commented 2 years ago

Description

twistcli has a parameter called --docker-address so that it can be used with custom Docker hosts. This change provides that feature.

Motivation and Context

This action is not usable without theses changes on certain workflows where a custom Docker host is used, for example buildx.

How Has This Been Tested?

Tested the workflow, with or without the changes

docker/setup-buildx-action@v1
docker/build-push-action@v2
PaloAltoNetworks/prisma-cloud-scan@v1

Types of changes

New feature (non-breaking change which adds functionality)

Checklist

[x] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes if appropriate.
[x] All new and existing tests passed.

welcome-to-palo-alto-networks[bot] commented 2 years ago

:tada: Thanks for opening this pull request! We really appreciate contributors like you! :raised_hands:

welcome-to-palo-alto-networks[bot] commented 2 years ago

:tada: Congrats on getting your first pull request merged! We here at Palo Alto Networks are so grateful! :heart: